Expose cuda device health status in /healthz endpoint #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
changed the title
papa99do
changed the title
papa99do
force-pushed
the
yihan/cuda-issue-mitigation
branch
2 times, most recently
from
d7c5d1c
to
ae4278e
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
commented
Dec 3, 2024
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
requested changes
Dec 3, 2024
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
reviewed
Dec 4, 2024
papa99do
force-pushed
the
yihan/cuda-issue-mitigation
branch
from
918a77e
to
d5ef430
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
vicilliar
requested changes
Dec 4, 2024
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
Dec 4, 2024
vicilliar
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Operation improvement
What is the current behavior? (You can also link to an open issue here)
Cuda device can silently fail, which causes weird behaviour of Marqo
What is the new behavior (if this is a feature change)?
Expose a /healthz endpoint to be called to check cuda device status. This endpoint will return 500 errors when
This endpoint can be used by any scheduling framework as a liveness check for Marqo container.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
No
Related documentation changes (link commit/PR here)
N/A
Other information:
Please check if the PR fulfills these requirements